Fix bug when switching from non-user-code to user-code #25381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @OwenKephart and the rest of your teammates on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title. Previous codepaths assumed that for a given instigator, the
handled_by_asset_daemonproperty would never change, which is not the case. To avoid this issue, we ignore the instigator state in these codepaths, and instead use the current value based off of the workspace snapshot.How I Tested These Changes
Added test which failed before these changes, and now passes.
Changelog
Fixed an issue which would cause
AutomationConditionSensorDefinitionsto not be evaluated if theuse_user_code_servervalue was toggled after the initial evaluation.